-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hard line break when backslash at EOL #1303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A backslash at the end of the line is a hard line break. Ref: https://spec.commonmark.org/0.28/#example-293
UziTech
approved these changes
Jul 3, 2018
styfle
approved these changes
Jul 6, 2018
Thanks! |
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
This was referenced Mar 30, 2020
This was referenced Apr 6, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
add hard line break when backslash at EOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backslash at the end of the line is a hard line break.
Ref: https://spec.commonmark.org/0.28/#example-293
Ref: https://spec.commonmark.org/0.28/#example-606
Ref: https://spec.commonmark.org/0.28/#example-609
Ref: https://spec.commonmark.org/0.28/#example-611
Marked version: master#b67b5fd2fcf9fd93e26ffbf10e20455803089467
Markdown flavor: CommonMark
Description
line 1 line 2\ line 3
Expectation
Result on commonmark.js demo
Result
Result on Marked Demo
What was attempted
I added the backslash rule to the
br
RegEx.Contributor
Committer
In most cases, this should be a different person than the contributor.